Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to rerun and cancel Runs #2418

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

AlanGreene
Copy link
Member

Changes

Related to #1970

  • Standalone Run resources can be rerun from the list page
    (i.e. not child of a Pipeline)
  • Any Run that is currently running (i.e. status == Unknown)
    can be stopped
  • Update StatusIcon to render running state to match behaviour
    described in the Runs documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2022
@AlanGreene AlanGreene removed the request for review from skaegi August 19, 2022 11:25
- Standalone Run resources can be rerun from the list page
  (i.e. not child of a Pipeline)
- Any Run that is currently running (i.e. status == Unknown)
can be stopped
- Update StatusIcon to render running state to match behaviour
  described in the Runs documentation
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022
@tekton-robot tekton-robot merged commit 63fe449 into tektoncd:main Aug 19, 2022
@AlanGreene AlanGreene deleted the runs_rerun_cancel branch August 19, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants